Hello!
I would like to point out an issue in install.sh file.
According to this in Fedora's Wiki, usage of grub2-mkconfig -o /boot/efi/EFI/fedora/grub.cfg should be avoided on Fedora 34 and later. But running install.sh will run that command and overwrite /boot/efi/EFI/fedora/grub.cfg.
In my opinion only grub2-mkconfig -o /boot/grub2/grub.cfg is enough.
And for those whose /boot/efi/EFI/fedora/grub.cfg is overwritten, Fedora's wiki suggests to reinstall grub and the steps to reinstall is mentioned in the same.
Hello! I would like to point out an issue in
install.shfile. According to this in Fedora's Wiki, usage ofgrub2-mkconfig -o /boot/efi/EFI/fedora/grub.cfgshould be avoided on Fedora 34 and later. But runninginstall.shwill run that command and overwrite/boot/efi/EFI/fedora/grub.cfg. In my opinion onlygrub2-mkconfig -o /boot/grub2/grub.cfgis enough. And for those whose/boot/efi/EFI/fedora/grub.cfgis overwritten, Fedora's wiki suggests to reinstall grub and the steps to reinstall is mentioned in the same.