vinceliuice / grub2-themes

Modern Design theme for Grub2
GNU General Public License v3.0
3.55k stars 245 forks source link

Fix arguments being passed while authenticating #95

Closed stuarthayhurst closed 4 years ago

stuarthayhurst commented 4 years ago

Changes:

vinceliuice commented 4 years ago

It not working on dialog mode

stuarthayhurst commented 4 years ago

Alright, let me take a look at it, I'll try and fix it then make a new request

stuarthayhurst commented 4 years ago

I misinterpreted what the code was doing, with the old method it still fails when --custom-background is used, so I'll add a fix for it

vinceliuice commented 4 years ago

only add --${theme} --${icon} --${screen} is works well

stuarthayhurst commented 4 years ago

Yes, but if --boot or --custom-background are used, then these won't have any effect if the wasn't called with root and uses dialog mode

stuarthayhurst commented 4 years ago

Never mind, I misunderstood those code, again You can ignore what I said and leave it as is, I totally forgot dialog mode is only used if no arguments are given

vinceliuice commented 4 years ago

Yes! Dialog mode is used for only run ./install.sh