search

vincelwt / harmony

:musical_note: Sleek music player for Spotify, SoundCloud, Google Play Music and your local files
http://getharmony.xyz
859 stars 59 forks source link

Unable to CMD+Q when starting from source on Mac OS #104

Closed ghost closed 7 years ago

ghost commented 7 years ago

Every other app does this, and it's actually a simple fix. Keyboard shortcuts can be registered on app startup, and "freed" (deregistered really) on app quit.

vincelwt commented 7 years ago

That's weird, the app should already quit with Cmd+q :/ Can you see the menu option in the menu bar to quit the app when the app is focused ?

ghost commented 7 years ago

Update: It looks like I can hit CMD+Q on the actual app itself, just not when I debug it from source by running npm start on the project directory. That launches Harmony via the electron app (not the actual compiled app on getharmony.xyz) and I can't hit cmd+q on that. I still think this should be handled, because I'm not sure why there's a discrepancy.

vincelwt commented 7 years ago

@ctnordcl Thanks for reporting, I'll try fixing that when I can get my hands on a Mac.

ghost commented 7 years ago

No worries, I'll try and get a PR up for this soon. I have a Mac that I use for work (automated test engineer here) that I can test this on.

vincelwt commented 7 years ago

That'd be great, thanks :)

ghost commented 7 years ago

Update, looks like it allows you Cmd+Q only before youve started playing a song. This goes for both the source and compiled apps. At least, this is the way it works on for me playing Seven Nation Army via Spotify, not sure how it works for other music services. Cmd+Q did not work after the music started playing.

ghost commented 7 years ago

Fixed! See my PR about Menu building, it includes a fix for this.