Arc theme almost integrate [WIP]

vincelwt / harmony

:musical_note: Sleek music player for Spotify, SoundCloud, Google Play Music and your local files

http://getharmony.xyz

859 stars 59 forks source link

Arc theme almost integrate [WIP] #118

Closed ghost closed 7 years ago

ghost commented 7 years ago

Working on it

vincelwt commented 7 years ago

Hi! Thanks for the contribution :) Some things to correct:

Maybe in the future Ctrl+a will be used to select all tracks, so I don't think it should be used to toggle this one. Maybe add an option to select a dark style between normal dark and your arc ? So we only keep Ctrl+d
About the CSS transitions, I don't think they should be in a subtheme, they should be in the main CSS so they work with all themes. You could maybe put it on another Pull request ?

ghost commented 7 years ago

Hi! Thank you for the information i will try to make a new pull request with all the conditions you said.

NickFlamel commented 7 years ago

Why not just have a drop-down in the settings page for themes, one for dark mode and one for light mode? So if people want to make their own themes, they can add them easily

vincelwt commented 7 years ago

@NickFlamel Next release will now support external themes. Themes will be added to https://github.com/vincelwt/harmony-themes/

@mandruis I'll try adapting your theme to add it to the repo.