search

vincelwt / harmony

:musical_note: Sleek music player for Spotify, SoundCloud, Google Play Music and your local files
http://getharmony.xyz
859 stars 59 forks source link

Stream for deezer is from youtube? #128

Closed aeruhxi closed 7 years ago

aeruhxi commented 7 years ago

As I looked into the code base, I found stream is being gotten from youtube in Deezer integration (searching with artist + song name and even using duration to get the best result). Is this true or did I misunderstand the code?

aeruhxi commented 7 years ago

This is not really an issue. Just asking if we could improve upon this?

vincelwt commented 7 years ago

Hi, Yes, as Spotify and Deezer don't allow direct streaming of their tracks, Harmony fetch their tracks on YouTube. This isn't a perfect solution but it is the only one that I see as of now :/

aeruhxi commented 7 years ago

I don't know about spotify but Deezer does provide JS SDK for the player. But the downside is it requires flash and the player integration might be different from what we are doing.

vincelwt commented 7 years ago

Yes, I meant like Soundcloud, a way to fetch the audio directly.