search

vincelwt / harmony

:musical_note: Sleek music player for Spotify, SoundCloud, Google Play Music and your local files
http://getharmony.xyz
859 stars 59 forks source link

Port to ES6 & some code clean up #138

Closed jakejarrett closed 7 years ago

jakejarrett commented 7 years ago

Ports over a majority of the code to ES6 (Added comments where the code was a bit unclear as to its purpose / end result)

There were some parts of the code i was not comfortable editing (Some of the API's, as i do not use / have an account on their services i was unable to test & check for regressions)

Cleaned up if statements to utilize variables when they were long (EG/ debian & appimage if statement in player)

Where possible, I'd also utilized strict equality (===) over abstract equality (==)

Ideally this should be pushed into a dev branch where it can be tested by others before being pushed into the master

vincelwt commented 7 years ago

Thanks a lot! This is awesome :)

I've created a newcode branch to work on the transition. I've never really worked with static methods, etc... so this is quite new for me. I'll try adpating future code to it.

jakejarrett commented 7 years ago

Awesome :smile_cat: