search

vincelwt / harmony

:musical_note: Sleek music player for Spotify, SoundCloud, Google Play Music and your local files
http://getharmony.xyz
859 stars 58 forks source link

Harmony can't synchronize the feed of Soundcloud #156

Closed unixfox closed 7 years ago

unixfox commented 7 years ago

Harmony is unable to synchronize the feed of Soundcloud but it can for the liked tracks (maybe it really can't but it fetch the liked tracks from the cache).

Logs

We are on a -linux- system
player.js:237 Mediakeys module not found.
player.js:288 Error loading MPRIS module
(anonymous) @ player.js:288
player.js:289 Error: The module '/opt/Harmony/resources/app/node_modules/dbus/build/Release/dbus.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 50. This version of Node.js requires
NODE_MODULE_VERSION 53. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or`npm install`).
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:173:20)
    at Object.Module._extensions..node (module.js:598:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:173:20)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/opt/Harmony/resources/app/node_modules/dbus/lib/dbus.js:3:13)
    at Object.<anonymous> (/opt/Harmony/resources/app/node_modules/dbus/lib/dbus.js:148:3)
(anonymous) @ player.js:289
utils.js:7 Testing internet...
main.js:431 listView
main.js:276 Latest release is v0.4.7 and we're running undefined
main.js:240 Everything over
main.js:431 listView
2main.js:431 listView
utils.js:7 Testing internet...
main.js:276 Latest release is v0.4.7 and we're running undefined
main.js:240 Everything over
main.js:431 listView

harmony_134

Information about the OS

vincelwt commented 7 years ago

Could you show the log when the library is refreshing ? (Small refresh button bottom left corner). The error with the MPRIS module is unrelated to that.

unixfox commented 7 years ago

harmony_137

vincelwt commented 7 years ago

@unixfox That is indeed weird, no errors are appearing. Just to be sure, are you following users on SoundCloud ? The feed is created from users you follow which posted/reposted tracks. So maybe you don't have a feed to show?

unixfox commented 7 years ago

It was working perfectly until today (I was listening yesterday music on Soundcloud using Harmony) so I tried to disconnect from Soundcloud on the settings and then relog but I faced to this issue #151 and I tried to upgrade the program. After that the feed was still blank. I did a big update of my system today so maybe yesterday I was using the 0.4.5 version, I could try to downgrade to it if you want. I'm following lot's of users: https://soundcloud.com/unixfox/following My stream on the webapp: selection_140

vincelwt commented 7 years ago

Mmh, it should indeed show some tracks on the feed tab. I'm curious to see if it works with 0.4.5! I don't remember changing anything related to the feed between 0.4.5 and 0.4.7

unixfox commented 7 years ago

It's working great using the 0.4.5 version, proof: harmony_141 It may be related to the API keys that you changed (?)

vincelwt commented 7 years ago

The API keys haven't really changed, only the server hosting them. If something were wrong with them, I don't think you would even be able to see your liked tracks. I'll check what else exactly changed between the versions see if I can fix it.

vincelwt commented 7 years ago

Found the bug! :) Simply a ! missing from the refactoring to ES6. I'm not using SoundCloud these days so I hadn't noticed it. Thanks for reporting, we'll be available with next release

unixfox commented 7 years ago

Nice, thank you for taking the time to resolve this issue.

I'll close the issue when the next version will be available to test if it works again.

vincelwt commented 7 years ago

No problems. I still have some other stuff to implement (great stuff coming) before 0.5 (next release) so it will be available a few days

vincelwt commented 7 years ago

Should be fixed with 0.5.0 :)

unixfox commented 7 years ago

Is it possible to add binary archive on the Download page like you did for the version 0.4.7 (harmony-0.4.7.tar.xz)?

PS: Sad news for me that Harmony is now closed source, I found Harmony by searching for a light open source player for Soundcloud instead of using Soundnode which consumes a lot. But it's your choice and I respect it.

vincelwt commented 7 years ago

@unixfox I removed the tar.xz build because there was already the .AppImage build (http://appimage.org/)., which should work with almost every distributions. Don't the .AppImage work on your system?

Unfortunately yes, Harmony is now closed-source, but I hope it will free me more time to work on it and make it way better.

unixfox commented 7 years ago

It's works on mine but I'm using a community package manager (https://wiki.archlinux.org/index.php/Arch_User_Repository) on ArchLinux who use directly the binary provided by the tar.xz, you can check this here: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=harmony-player#n18. And I think it's easier for the maintainer (kusti8) of the package harmony-player to use the archive instead of the .AppImage because the only thing that he has to do is to change the number version.

Apart from that, the feed works now perfectly.

vincelwt commented 7 years ago

Um ok I see. I'll build the tar.xz version this afternoon :) However the maintainer of the repo is going to need to change the name of the file a little because it will now be harmony-0.5.0-x64.tar.xz (with the arch).

About the original issue, were you able to test?

unixfox commented 7 years ago

Yes and the feed works perfectly. Thank you for everything!