search

vincelwt / harmony

:musical_note: Sleek music player for Spotify, SoundCloud, Google Play Music and your local files
http://getharmony.xyz
859 stars 58 forks source link

External plugins don't work #236

Open orzFly opened 5 years ago

orzFly commented 5 years ago

I am writing a new plugin and I put it at /Users/USER/Library/Application Support/Harmony/Plugins/node_modules/harmony-USER/index.js. package.json is also presented. The plugin won't load at all.

Root Cause I Think In `loadModules`: ``` > const modulesPaths = ["1"] undefined > modulesPaths.concat(["2"]) [ '1', '2' ] > console.log(modulesPaths) [ '1' ] undefined ``` `concat` won't modify the array instance. It returns an new Array. This should be why external plugins are not working at all.
vincelwt commented 5 years ago

Hi!

Funnily enough someone else reported exactly the same issue just a day before with the same fix. It'll be good with the next release of Harmony :)

I'm preparing to open-source back the core of Harmony, so this should happen less. Cheers!