vincelwt / harmony

:musical_note: Sleek music player for Spotify, SoundCloud, Google Play Music and your local files
http://getharmony.xyz
859 stars 58 forks source link

Google Play Music: empty or incomplete Playlists #84

Open JohannesKuhaupt opened 7 years ago

JohannesKuhaupt commented 7 years ago

I only use Harmony with Google Play Music. All Google Music playlists appear on the left sidepane. So far so good. But not all playlists are loaded correct. The "thumbs up" playlist seems correct and contains all songs. But other playlists are empty or songs are missing. So these playlists don't contain all the songs, which is very annoying. The missing songs appear in the global Google Music Playlist or in the "thumbs up" playlist. This problem affects normal playlists and offline playlists.

System: Linux Mint 18 XFCE / Ubuntu 16.04 Base / amd64 Harmony 0.3.2

A fix for this problem would be very nice ;-)

btw: Harmony is a great music app with a very clean interface!

Thanks, Johannes

vincelwt commented 7 years ago

Hi! Are you using Google Play Music all access ? Do find something in common with the disappearing tracks ? Maybe only all-access tracks are disappearing ? That would be a great help.

JohannesKuhaupt commented 7 years ago

Hi, I don't know what you mean with "all-access tracks". I'am using the Google Play Music Flatrate (I pay every month) and uploaded some songs, which I haven't found on Google Music. The disappeared tracks / missing tracks are both types. Some uploaded tracks are missing and some Google Music tracks are missing. I can't figure out any similarities / things that the missing tracks have in common. Sorry.

And I have to correct my frist bug post. The Global Google Music Playlist has also missing tracks. So I think, that there is a global missing track problem with Google Play Music.

Edit: I tried to logout G Music and login again. Nothing changes. Still missing tracks!

vincelwt commented 7 years ago

Mmh, could you try opening developer tools (press Ctrl+Alt+i), go to the console tab and copy paste everything ? See if an error popped up

ManuelPimienta commented 7 years ago

error_harmony Hello, I try to login on Google Play Music and failed to start session, and now can not close the setting manager because asks me for the Google account. Sorry for my english, and thanks for the software.

vincelwt commented 7 years ago

@ManuelPimienta Try resetting all the settings and data (at the bottom of settings page)

JohannesKuhaupt commented 7 years ago

Sorry I am on tour. I installed Harmony on my notebook and got the same error / problem.

There is one error message: "Uncaught TypeError: Cannot read property 'playlists' of undefined (utils.js:74)"

ManuelPimienta commented 7 years ago

@vincelwt It's works, thanks.

vincelwt commented 7 years ago

@JohannesKuhaupt I don't think this is the error causing the problem. Could you copy paste the whole output ? because some errors are printed like infos but are still errors (I need to correct that)

JohannesKuhaupt commented 7 years ago

This is the console output:

We are on a -linux- system Mediakeys module not found. changed ObjectIdentity: "Harmony"proto: Object changed Object changed Object local fetched, testing internet Testing internet... listView Latest release is v0.3.2 and we're running undefined Everything over listView listView

When I select one empty playlist (which is usually not empty), there is this error: player.js:86 Uncaught TypeError: Cannot read property 'title' of undefinedplayTrack @ player.js:86playByIndex @ main.js:6ondblclick @ index.html:1 2main.js:411 listView

vincelwt commented 7 years ago

The error you're reporting is because when you double clicked on the playlist, as there is no tracks in this playlist, it can't play the first track. But that's not the why of the problem, so it must be something with the Google Music API

JohannesKuhaupt commented 7 years ago

Sorry, I can't produce other error messages

arvigeus commented 7 years ago

I had the same problem when tried Harmony 0.2. Will watch this thread for development.

JohannesKuhaupt commented 7 years ago

Tried Harmony 0.44a (current version, with config reset) and still got the same problem.

fernangz commented 7 years ago

0.4.4 - Only 3 playlists are loading content on Windows, the others (I have 30 playlists) don't show anything.

vincelwt commented 7 years ago

Should be fixed with next release (0.5.1) :)

vincelwt commented 7 years ago

0.5.1 released, could you try to confirm?

JohannesKuhaupt commented 7 years ago

I tried 0.5.1 and it seems way better. Many missing songs are now visible in playlists. But there are still some empty playlists. Sorry :-/ But it is a big step forward!

vincelwt commented 7 years ago

@JohannesKuhaupt Noted. How large is your library? Would you say more than 40k tracks?

JohannesKuhaupt commented 7 years ago

About 9-10k tracks,

vincelwt commented 7 years ago

Are this time, the missing tracks, song you bought? Or is there also missing songs you uploaded?

JohannesKuhaupt commented 7 years ago

Both!

ericfernandez commented 7 years ago

Hey there! I also seem to have this problem with Google Play Music. None of my playlists come over.

The console outputs the following: apiRequest @ /Applications/Harmony.app/Contents/Resources/app.asar/app/js/plugins/spotify.js:130 request @ /Applications/Harmony.app/Contents/Resources/app.asar/app/js/plugins/spotify.js:21 self.callback @ /Applications/Harmony.app/Contents/Resources/app.asar/node_modules/request/request.js:188 emitTwo @ events.js:106 emit @ events.js:194 (anonymous) @ /Applications/Harmony.app/Contents/Resources/app.asar/node_modules/request/request.js:1171 emitOne @ events.js:96 emit @ events.js:191 (anonymous) @ /Applications/Harmony.app/Contents/Resources/app.asar/node_modules/request/request.js:1091 onceWrapper @ events.js:293 emitNone @ events.js:91 emit @ events.js:188 endReadableNT @ _stream_readable.js:975 _combinedTickCallback @ internal/process/next_tick.js:80 _tickCallback @ internal/process/next_tick.js:104 /Applications/Harmony.app/Contents/Resources/app.asar/app/js/plugins/googlepm.js:154 Uncaught TypeError: Cannot read property 'push' of undefined at pm.getPlayListEntries (/Applications/Harmony.app/Contents/Resources/app.asar/app/js/plugins/googlepm.js:154) at /Applications/Harmony.app/Contents/Resources/app.asar/node_modules/playmusic/play.js:581 at IncomingMessage.<anonymous> (/Applications/Harmony.app/Contents/Resources/app.asar/node_modules/playmusic/play.js:86) at emitNone (events.js:91) at IncomingMessage.emit (events.js:188) at endReadableNT (_stream_readable.js:975) at _combinedTickCallback (internal/process/next_tick.js:80) at process._tickCallback (internal/process/next_tick.js:104) pm.getPlayListEntries @ /Applications/Harmony.app/Contents/Resources/app.asar/app/js/plugins/googlepm.js:154 (anonymous) @ /Applications/Harmony.app/Contents/Resources/app.asar/node_modules/playmusic/play.js:581 (anonymous) @ /Applications/Harmony.app/Contents/Resources/app.asar/node_modules/playmusic/play.js:86 emitNone @ events.js:91 emit @ events.js:188 endReadableNT @ _stream_readable.js:975 _combinedTickCallback @ internal/process/next_tick.js:80 _tickCallback @ internal/process/next_tick.js:104

vincelwt commented 7 years ago

@ericfernandez I may have have fixed this in next release, I'll let you know when available