vincent-hugot / qtest

Inline (Unit) Tests for OCaml
GNU General Public License v3.0
67 stars 8 forks source link

support lexer directives in input files #45

Closed gasche closed 7 years ago

gasche commented 7 years ago

In Batteries it would be helpful to have qtest recognize lexer directives in input files (it gives compilation errors in the right place for test that comes from preprocessed .mlv files).

c-cube commented 7 years ago

So, this makes #line foo and the likes parsed properly? Good idea, thanks. Would it also work for, say, cppo?

gasche commented 7 years ago

I updated the PR with a cppo test. It works just fine.

c-cube commented 7 years ago

Very nice, thanks. Would you want me to release quickly?

gasche commented 7 years ago

Do as is convenient for you for the release -- it will be a nice ergonomic improvement, but it's not blocking anything Batteries-wise.