search

vincent-hugot / qtest

Inline (Unit) Tests for OCaml
GNU General Public License v3.0
67 stars 8 forks source link

generated code lines longer than 80 chars #9

Closed UnixJunkie closed 8 years ago

UnixJunkie commented 11 years ago

That may be nice to have them shorter so that people can eyeball them more comfortably or even edit them if they need to.

vincent-hugot commented 11 years ago

or even edit them if they need to.

Hum, you're not supposed to edit them... except for quick debugging, maybe.

Could make them shorter, but editing should be discouraged...

UnixJunkie commented 11 years ago

On 05/14/2013 11:52 AM, Vincent Hugot wrote:

or even edit them if they need to.

Hum, you're not supposed to edit them... except for quick debugging, maybe.

Could make them shorter, but editing should be discouraged...

People who troubleshoot may need to go under the hood quite often. ;)

UnixJunkie commented 11 years ago

The code should even be pretty printed in fact, in addition to having no lines being too long.

I am already having to dig inside some code generated by qest...

vincent-hugot commented 11 years ago

I can't/shouldn't touch the extracted code itself, for line/col synchronisation reasons.

I can certainly improve the "dressing", though; a little more whitespace/newlines can't hurt.

entry point: qtest.mll: generate, especially core.ml: process.

c-cube commented 8 years ago

@UnixJunkie does it also happen with "raw" tests? Those with (*$R or (*$QR? If not, I will close the issues, as most tests should be one line anyway.

UnixJunkie commented 8 years ago

It's OK to close, thanks.