search

vincent-lai / boxeeremote

Automatically exported from code.google.com/p/boxeeremote
0 stars 0 forks source link

Find Boxees endless loop #4

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Are you using Boxee or XBMC?
Boxee on ATV
What steps will reproduce the problem?
1. Menu
2. Find Boxees
3. If boxee remote does not find a boxee it never times out
4. Hitting the back button will cause the app to become unresponsive, needing a 
force close.

What is the expected output? What do you see instead?
A message after timeout saying that no boxees could be found would be nice

Please provide any additional information below.

Original issue reported on code.google.com by ty.tremb...@gmail.com on 30 Mar 2009 at 3:03

GoogleCodeExporter commented 8 years ago 
I'm looking into this and there are indications that this is a null pointer 
exception. 

I was in the process of tracking the issue down when life interrupted me. I 
will post 
back with more details and perhaps a patch if I can get that far.

Original comment by cemetery...@gmail.com on 1 Apr 2009 at 5:31

GoogleCodeExporter commented 8 years ago 
Oh, wow, I didn't think you were going to try to fix it! I'll try to take a 
look at
this later, but I think you're right that I send null if the receive times out 
and
then don't check for null in BoxeeRemote.addAnnouncedServers.

Original comment by chat...@gmail.com on 1 Apr 2009 at 5:39

GoogleCodeExporter commented 8 years ago 
Very cool. I will work with you on this issue. I find this application useful 
and I 
am interested in seeing it mature.

I have the latest revision (R58 at the moment) running in the emulator so if I 
get 
anywhere with a fix I will surely notify you. I also have some other issues in 
the 
application which I want to report and work on.

How would you like to receive code submissions? Should I email a patch, attach 
it as 
a file to this Issue, or what?

Original comment by cemetery...@gmail.com on 1 Apr 2009 at 6:21

GoogleCodeExporter commented 8 years ago 
It would be great if you can upload it to
http://codereview.appspot.com/, as that makes it easy for me to read
and comment on. You can get a script from
http://code.google.com/p/rietveld/wiki/CodeReviewHelp that uploads a
diff from the svn tree automatically. If that's too much trouble, I
don't mind getting short diffs as a patch.

Original comment by chat...@gmail.com on 1 Apr 2009 at 6:34

GoogleCodeExporter commented 8 years ago 
It was a small patch, so I sent you an email at 
andrew-[at]-andrewchatham-[d0t]-com 
with the patch as an attachment. The subject line is "BoxeeRemote Patch (Issue 
4)"

It is currently running on my phone and doesn't seem to break anything.

Original comment by cemetery...@gmail.com on 2 Apr 2009 at 3:16

GoogleCodeExporter commented 8 years ago

Original comment by chat...@gmail.com on 3 Apr 2009 at 3:01