search

vincent0955 / Visual-metronome

visual metronome plugin for runelite
BSD 2-Clause "Simplified" License
7 stars 10 forks source link

[Bug] Lowering number of colors can break plugin #2

Closed saltedpotatos closed 3 years ago

saltedpotatos commented 3 years ago

If you lower the number of colors and your tickCounter is greater than your colorCycle / number of colors, the plugin will go to the 10th tick color and get stuck until you disable and re-enable the plugin.

Taking a quick peek, I'm guessing you can alter the if check here , but maybe catching the config change and resetting the tickCounter would be a cleaner long term solution

vincent0955 commented 3 years ago

Thanks for notifying me, I see the problem. I'll check it out, I'll probably just make it reset the TickCounter when the config is changed.

vincent0955 commented 3 years ago

Fixed in V1.2.3, thanks.