search

vincent0955 / Visual-metronome

visual metronome plugin for runelite
BSD 2-Clause "Simplified" License
7 stars 10 forks source link

Fix #19 #26

Closed Thource closed 1 year ago

vincent0955 commented 1 year ago

Hey, you actually changed the whole implementation along with fixing the issue, it looks like you didn't take into account that the tickCounter number is actually shown to the client if the feature is on. So simplifying the implementation like you did would mess up the showTick and showPlayerTick features.

I went ahead and made my own commit with the fix you made but did it without changing the plugin implementation, hope you don't mind. Thanks for fixing the issue.

vincent0955 commented 1 year ago

https://github.com/vincent0955/Visual-metronome/commit/a4737dfd68d942236f288458c8d07883f63f30d2

Thource commented 1 year ago

Oops, I did check showTick and showPlayerTick but maybe it was 1 based and I made it 0 based? Glad it’s fixed anyway :)

vincent0955 commented 1 year ago

Yeah that, and also if config.tickCount() was set to 1, it would just stay at 0 instead of cycling through the numbers when you simplified it to 1 switch statement; though I am now just realizing that it can be fixed by adding checks to see if (config.tickCount() == 1) in the overlay files to choose which variable to display.