vincent0955 / Visual-metronome

visual metronome plugin for runelite
BSD 2-Clause "Simplified" License
7 stars 10 forks source link

Future Request: Improved tile indicator compatibility #29

Open 69spacecowboy opened 1 year ago

69spacecowboy commented 1 year ago

I was wondering if its possible to have the visual metronome true tile overlay be compatible with improved tile indicators, or to have it render under the character without overlapping the model, thank you!

vincent0955 commented 1 year ago

I checked out the improved tile indicators plugin and it looks like they use some pretty complicated techniques to get the indicators to render under the character models, and unfortunately the only way to do this is to recreate the whole thing, and I don't think I could or should try to do that for this plugin. Thanks for the suggestion

iatethedinosaurs commented 7 months ago

Hello, I had an idea and changing line 38 in VisualMetronomeTileOverlay.java from: setLayer(OverlayLayer.UNDER_WIDGETS); to setLayer(OverlayLayer.ABOVE_SCENE); got it working with Improved Tile Indicators to render the Tile Metronome under the models instead of over. Not sure if it breaks anything else, will continue running it and see if I run across anything that seems broken.

vincent0955 commented 7 months ago

Hey, I'll check it out in about a few days and update you to see if it works.

vincent0955 commented 7 months ago

Hey, it doesn't seem to work. I changed it to setLayer(OverlayLayer.ABOVE_SCENE); and it still renders over models.

iatethedinosaurs commented 7 months ago

Do you also have the Improved Tile Indicator plugin enabled? It has to be enabled, since it's what makes the overlays render under the character. This is after making that edit.

javaw_gfizKJ3gug

vincent0955 commented 7 months ago

Oh i see, it works now. Didn't know the change would be this simple to make it work with Improved Tile Indicators. Thanks for letting me know.