search

vincent64 / minecraft-chat-history

View your Minecraft chat history with color and font formatting.
Other
2 stars 0 forks source link

Improve path handling a little #1

Closed Cecer closed 7 months ago

Cecer commented 7 months ago

This cleans up handling paths by using the NIO Path API rather than directly building strings. It also handles other operating systems properly by not just assuming it's Windows if it's not OSX. I have no idea if the project even works on other operating systems, even with these changes, but it's an improvement nonetheless.

I tried to avoid changing too much but I did clean up the many versions of the path fields.

FYI: I haven't actually tested it as you have a non-standard build environment. This is also why I simply duplicated PathHelper.java and OS.java into both packages rather than share a common module.

vincent64 commented 7 months ago

Thank you for your pull request! Your changes are really good, I will merge the pull request. :)