vincentarelbundock / WDI

R package to download World Bank data
http://vincentarelbundock.github.io/WDI
212 stars 61 forks source link

Check API for new features #42

Closed vincentarelbundock closed 2 years ago

vincentarelbundock commented 3 years ago

Links initially posted by @etiennebacher

For reference, here are a few links that could give ideas for new features:

vincentarelbundock commented 3 years ago

For the record, I don't have a restricted view on package scope necessarily, beyond time constraints. Everything on the WB API page should be fair game if anyone is interested in adding it.

etiennebacher commented 3 years ago

Hello, after checking the page with V2 new features, I think that it would be useful to add two of them in WDI:

What do you think? I know that you want to limit the number of arguments in WDI, but this download option could be useful.

If you're okay with that, I can do the changes and prepare a PR.

vincentarelbundock commented 3 years ago

Thank for looking into this!

Adding observation status to extra sounds like a no brainer. Great!

On download, how does this compare to WDIbulk and WDIcache?

(Note: I'm on semi-vacation with sporadic access to Github, so I might not react super quickly)

etiennebacher commented 3 years ago

If I'm correct, WDIcache does not provide any data but a list of indicators, and WDIbulk downloads all WDI indicators without exception. The argument download would be used in WDI to download a csv/excel file that contains only the data we want. For instance, if I already have:

WDI("FR", "SP.POP.TOTL", start = 1990, end = 2000)

then download would only create a csv containing "SP.POP.TOTL" for France between 1990 and 2000.

I'll do a PR at least to include observation status.

vincentarelbundock commented 3 years ago

Sounds good on the PR.

Honestly, I'm not convinced by the download option. In my own work, when I need to ensure 100% replicability, I typically call WDI once and then save the results as a CSV or RDS file. Then, I comment out the WDI call and load from file.

etiennebacher commented 3 years ago

Right, I do some similar stuff too. I'll only focus on the obs status then, probably PR this weekend.

vincentarelbundock commented 3 years ago

sounds great, thanks. I do think the observation status is super cool.

vincentarelbundock commented 2 years ago

Closing this now since I don't think we had anything concrete planned. Feel free to open new issues if you have specific feature requests or ideas.

Thanks!