search

vincentarelbundock / countrycode

R package: Convert country names and country codes. Assigns region descriptors.
https://vincentarelbundock.github.io/countrycode
GNU General Public License v3.0
342 stars 83 forks source link

Fix Namibia when code is `NA` #262

Closed dieghernan closed 3 years ago

dieghernan commented 3 years ago

Fix #261

I also update how the info is imported to Eurostat, since NA on the source file are valid values

dieghernan commented 3 years ago

Cancelled as it was fixed in https://github.com/vincentarelbundock/countrycode/commit/a88d04056b5d28a3dddefa85c28c5c2864294b60

vincentarelbundock commented 3 years ago

Thanks a bunch for this PR @dieghernan ! I really appreciate all the effort you put in, even if I pushed a different way.

dieghernan commented 3 years ago

No worries @vincentarelbundock , a fix is a fix. Still have to check if your approach may have some impact, i.e. users identifying EU countries with is.na(codelist$eu28) may have problems, but:

  1. I still am not able to check it locally
  2. I am not sure if it would be something to fix, as it may not be the intended usage of the package