vincentarelbundock / countrycode

R package: Convert country names and country codes. Assigns region descriptors.
https://vincentarelbundock.github.io/countrycode
GNU General Public License v3.0
342 stars 83 forks source link

test that a custom dictionary with unique column names works #271

Closed cjyetman closed 3 years ago

cjyetman commented 3 years ago
  1. I think this might conflict with custom dictionaries where we won't know the names of the columns, and hence the possible values for origin or destination.

Originally posted by @cjyetman in https://github.com/vincentarelbundock/countrycode/issues/270#issuecomment-805596311

Based on the above comment, it would probably be a good idea to have a test that tests if a custom dictionary with unique column names works.

vincentarelbundock commented 3 years ago

Could you clarify a bit how this differs from:

https://github.com/vincentarelbundock/countrycode/blob/main/tests/testthat/test-custom-dictionary.R

cjyetman commented 3 years ago

these indirectly cover it, so closing https://github.com/vincentarelbundock/countrycode/blob/e85e44f4505d55d8b09c888f78b5eaf47df96fbc/tests/testthat/test-custom-dictionary.R#L22-L24