Closed cjyetman closed 3 years ago
Could you clarify a bit how this differs from:
https://github.com/vincentarelbundock/countrycode/blob/main/tests/testthat/test-custom-dictionary.R
these indirectly cover it, so closing https://github.com/vincentarelbundock/countrycode/blob/e85e44f4505d55d8b09c888f78b5eaf47df96fbc/tests/testthat/test-custom-dictionary.R#L22-L24
Originally posted by @cjyetman in https://github.com/vincentarelbundock/countrycode/issues/270#issuecomment-805596311
Based on the above comment, it would probably be a good idea to have a test that tests if a custom dictionary with unique column names works.