search

vincentarelbundock / countrycode

R package: Convert country names and country codes. Assigns region descriptors.
https://vincentarelbundock.github.io/countrycode
GNU General Public License v3.0
346 stars 84 forks source link

'korea, dem. rep.' should be north korea, not south #286

Closed iamgyang closed 3 years ago

iamgyang commented 3 years ago

countrycode("korea, dem. rep.", 'country.name', 'iso3c') gives "KOR", not "PRK".

NilsEnevoldsen commented 3 years ago

Hm. Is this test passing? https://github.com/vincentarelbundock/countrycode/blob/bffe4c78e48e3cccf8e161d3d622228672e9db28/tests/testthat/data-known-name-variations.R#L96

iamgyang commented 3 years ago

Sorry--I had to delete and reinstall the package. Fixed now. My bad!

NilsEnevoldsen commented 3 years ago

Ah, fixed in https://github.com/vincentarelbundock/countrycode/commit/0e618a5c0aec3a8aabedfac0394e339d5b37cd48.