vincentarelbundock / countrycode

R package: Convert country names and country codes. Assigns region descriptors.
https://vincentarelbundock.github.io/countrycode
GNU General Public License v3.0
342 stars 84 forks source link

Various changes #311

Closed vincentarelbundock closed 1 year ago

vincentarelbundock commented 2 years ago

Samuel via email suggests:

I do not know the answer yet, but I had a weird meaning unsuccessful behavior with the following country names when using country.name.de

There are some missing genc2c, genc3c, iso2c, iso3c, iso3 values for entries countrycode::codelist. Where they deleted because of country divisions/splits? For me the old code is still useful, because of people that have still passports with the old country name.

Is there a solution for groups and regions?

samkulu commented 2 years ago

Thank you Vincent, for the deployment of latest improvements.

As soon as I have more time I will have a look into custom_match or custom_dict arguments. I have already prepared some other lists (e.g. NATO, INTERPOL, EU27, EFTA, exEFTA, UN, LOCODE) and would be glad that the work is not all gone.

By the way, I have found this tutorial from Steven V. Miller with the different classification systems: http://svmiller.com/blog/2021/01/a-tutorial-on-state-classification-systems/ From this article I browse to the GENC Webpage (see https://nsgreg.nga.mil/genc/discovery) where I am reading, that GENC is the official profile of ISO3166 for US law and government. (Vincent: "The script to download and clean the genc codes is here if you are curious: https://github.com/vincentarelbundock/countrycode/blob/main/dictionary/get_genc.R "). This is interesting for me, because ...

Switzerland has its own recognition of states and goverments. The PDF-Files in de, fr, it and en can be found here: https://www.eda.admin.ch/eda/en/fdfa/foreign-policy/international-law/respect-promotion/the-recognition-of-states-and-governments.html It seems to me that the Swiss FDFA list gets updated 1-3 times a year. As soon as I have time I intend do create an own R-Function (e.g. get_ch_recognition.R).

B.R. Samuel

samkulu commented 2 years ago

Hi Vincent,

We have found another good source, that seems to incorporated the official Swiss country recognition very well. For hosting a function like the "get_genc.R" this should be much easier to check than a pdf version from the EDA.

https://www.bfs.admin.ch/bfs/de/home/grundlagen/stgb.assetdetail.22870013.html

BFS (Bundesamt für Statistik) is the Federal Statistical Office of Switzerland. Could you have a look into the table and tell me whether it is more efficient to keep it as is? Or do we need to translate it into a custom csv dictionaries?

B.R. Samuel

vincentarelbundock commented 2 years ago

I thought GENC was a US government code list. Are the codes in your link really GENC? What are the differences between those and the ones we already have?

Underlying those questions is my reflex of "if it ain't broke, don't fix it". There needs to be clear added value.

vincentarelbundock commented 1 year ago

I have integrated the info in this issue into the relevant other issues. Closing this now to avoid duplication.