'Germany' used inconsistently as value for `country.name.en`

vincentarelbundock / countrycode

R package: Convert country names and country codes. Assigns region descriptors.

https://vincentarelbundock.github.io/countrycode

GNU General Public License v3.0

342 stars 84 forks source link

'Germany' used inconsistently as value for `country.name.en` #328

Open smoser11 opened 1 year ago

smoser11 commented 1 year ago

Howdy. I'm sorry if I'm being dense, but why are West Germany ( German Federal Republic , cown= 260) given the same English -- and German -- name of post-unification Germany (Germany, cown = 255) ? This seems to introduce unnecessary ambiguity in the codelist_panel data included in the package. The countrycode package does (correctly) treat East Germany (German Democratic Republic, cown = 265) separate from 'Germany.'

Is there a reason for this?

vincentarelbundock commented 1 year ago

The panel build script is here: https://github.com/vincentarelbundock/countrycode/blob/main/dictionary/build.R#L68

I'd be happy to merge a pull request if you have improvements to suggest. ;-)