search

vincentarelbundock / countrycode

R package: Convert country names and country codes. Assigns region descriptors.
https://vincentarelbundock.github.io/countrycode
GNU General Public License v3.0
342 stars 84 forks source link

New release on CRAN? #356

Closed etiennebacher closed 5 months ago

etiennebacher commented 5 months ago

Hi Vincent, there are a couple of improvements and speedups in the development version, do you have an idea of when you'd like to submit it to CRAN? No pressure from my side, I'd just prefer using the CRAN version than the dev one.

Btw the last two items in NEWS don't appear on the website, it seems there's no automated workflow for altdoc on this repo.

vincentarelbundock commented 5 months ago

thanks for the nudge. website fixed and package submitted to cran

etiennebacher commented 5 months ago

Cool, thanks. Also the badge for download counts is wrong since altdoc adds the ".png" extension (I thought we had fixed that in altdoc)

vincentarelbundock commented 5 months ago

Thanks. should be fixed now.

The problem is that knitr is trying to be too clever by adding the extension. There's some preamble we can add to remove that behavior, but that messes things up with Quarto websites and the index.qmd file. A different solution would be to do some regex, but that's ugly and dangerous. Another solution is to simply use an html link with <a></a>.

In the end, I decided that that solution was easy enough, and that the other solutions problematic enough to not fix this directly in altdoc.