This PR addresses issue #8 to ensure that the CI checks pass. This PR is a stop-gap solution to clean up the CI checks so that future failures can be caught expeditiously. Some of the polars functionality blurs the line mentioned in the a comment in the parent issue. For a future PR it is my belief the polars tests should be re-worked. This PR keeps the polars functionality to ensure that scenarios are tested even if in a non-optimal way.
Changes Made
Update formatting of countrycode to ensure that the linting CI check passes.
Updated the test workflow to add steps to install polars and run tests denoted as *_polars
Update custom_strategies to reflect the dictionary representation of codelist
Add empty_string_to_null helper function to account for the dictionary representation of codelist coercing empty string values (previously seen as None natively) to None
Migrate prior custom_strategies to custom_strategies_polars. Based on comments on the issue thread itself I would like to sunset these as soon as possible but am leaving them in for this PR until we have conversion unit tests for the dictionary representation of codelist
Move test_numeric to test_conversion_polars. When using the dictionary representation of codelist the iso3n column was the string representation of a number rather than a number. We can solidify this behavior when porting the tests to not use polars
Skip all tests that need polars if polars is not installed. The skips occur at the module and file levels.
Considerations
I created this PR with the intent of getting the tests to pass as my first objective. We can migrate the conversion tests and sunset some polars functionality in later PRs.
Summary
This PR addresses issue #8 to ensure that the CI checks pass. This PR is a stop-gap solution to clean up the CI checks so that future failures can be caught expeditiously. Some of the
polars
functionality blurs the line mentioned in the a comment in the parent issue. For a future PR it is my belief thepolars
tests should be re-worked. This PR keeps thepolars
functionality to ensure that scenarios are tested even if in a non-optimal way.Changes Made
countrycode
to ensure that the linting CI check passes.polars
and run tests denoted as*_polars
custom_strategies
to reflect the dictionary representation ofcodelist
empty_string_to_null
helper function to account for the dictionary representation ofcodelist
coercing empty string values (previously seen asNone
natively) toNone
custom_strategies
tocustom_strategies_polars
. Based on comments on the issue thread itself I would like to sunset these as soon as possible but am leaving them in for this PR until we have conversion unit tests for the dictionary representation ofcodelist
test_numeric
totest_conversion_polars
. When using the dictionary representation ofcodelist
theiso3n
column was the string representation of a number rather than a number. We can solidify this behavior when porting the tests to not usepolars
polars
ifpolars
is not installed. The skips occur at the module and file levels.Considerations
polars
functionality in later PRs.