vincentarelbundock / pymarginaleffects

GNU General Public License v3.0
47 stars 8 forks source link

Fix datagrid's grid_type parameter check #104

Closed danielkberry closed 1 month ago

danielkberry commented 1 month ago

The assert is checking for ["mean_or_mode", "explicit", and "counterfactual"] when explicit is not a valid parameter, balanced is. This means that the balanced code path is currently not usable (calls to datagrid with grid_type="balanced" will fail).

vincentarelbundock commented 1 month ago

Thanks a ton for spotting this and taking the time to investigate. I really appreciate it!

Merged.