search

vincentarelbundock / pymarginaleffects

GNU General Public License v3.0
47 stars 8 forks source link

Fix bug when `pyfixest.feols()` does not have fixed effects #79

Closed s3alfisc closed 5 months ago

s3alfisc commented 5 months ago

Hi @vincentarelbundock, this PR:

In this or a later PR, I will add tests for IV via feols() + add tests for standard errors. predict() with newdata is not yet supported for fepois, so I'll add tests when I have implemented this in pyfixest. And pyfixest's predict() method currently fails with newdata and fixed effects interacted via fe1^fe2 syntax - that's why the tests are commented out (see this issue).

vincentarelbundock commented 5 months ago

Looks awesome, thanks so much for this!

I'll release to pypi in the coming days. I look forward to playing more with pyfixest.

s3alfisc commented 5 months ago

Super cool! Same applies for me with pymarginaleffects! =)