search

vincentbernat / haproxy-debian-repository-wizard

Web application to select the appropriate Debian repository for HAProxy
https://haproxy.debian.net
10 stars 7 forks source link

Travis comes handy #4

Open szepeviktor opened 7 years ago

szepeviktor commented 7 years ago

Please consider adding html validator: https://github.com/szepeviktor/ip-info/blob/gh-pages/.travis.yml

vincentbernat commented 7 years ago

Will it work with the Angular stuff?

szepeviktor commented 7 years ago

Please enable Travis (first) then open a PR. I think yes.

vincentbernat commented 7 years ago

I have tried locally, then run:

$ html5validator --ignore-re 'Attribute "ng-[a-z-]+" not allowed'
WARNING:html5validator.validator:"file:/home/bernat/code/debian/haproxy-repository/www/./index.html":5.9-5.70: error: A "meta" element with an "http-equiv" attribute whose value is "X-UA-Compatible" must have a "content" attribute with the value "IE=edge".
"file:/home/bernat/code/debian/haproxy-repository/www/./index.html":27.9-27.17: error: Stray end tag "option".
"file:/home/bernat/code/debian/haproxy-repository/www/./index.html":97.42-97.122: error: Bad value "https://launchpad.net/~vbernat/+archive/haproxy-{{ selected.version }}" for attribute "href" on element "a": Illegal character in path segment: "{" is not allowed.

For the first one, I have removed the chrome=1 since Chrome Frame doesn't exist anymore. For the last one, I don't think there is much to do. Moreover, html5validator returns with status code 0 even when there are errors.

szepeviktor commented 7 years ago

html5validator returns with status code 0 even when there are errors.

My copy is returning non-zeros also: https://travis-ci.org/szepeviktor/ip-info/builds/83157895#L103