search

vincentcox / StaCoAn

StaCoAn is a crossplatform tool which aids developers, bugbounty hunters and ethical hackers performing static code analysis on mobile applications.
MIT License
828 stars 131 forks source link

Restored support for apks as default arguments #45

Closed Ayowel closed 6 years ago

Ayowel commented 6 years ago

Hi,

If a path is given as argument without the -p option, it is not recognised. This PR restores support for calls such as python3 stacoan.py yourApp.apk while still enabling the launch of a server by default.

This should not affect the server, however I can't test it at the moment (Address already in use error when I try to use the server, with or without this modification, even after a reboot).

vincentcox commented 6 years ago

Will look at the PR's when I am at home. Really, thank you 👍 for the feedback and effort put in this project. I think I will add you to the top contributor's list soon. About the address already in use: did you get that with the executables (from the releases)? Or did you get it when running the python source code?

Ayowel commented 6 years ago

Happens when running python3 stacoan.py in a Kali VM from the repository's code.

On a side note, I saw you talk about your inability to use Docker as you have VMWare installed. I am in the same situation and use docker by running it from a fedora VM ; you might want to look into this.

vincentcox commented 6 years ago

Did you tried to drag and drop an apk on it? It seems that the arguments are causing some trouble

Ayowel commented 6 years ago

No, as I said I can't seem to get the web interface to work no matter what I do. I'll look into it tomorrow and find a way to fix this.

vincentcox commented 6 years ago

I made some changes in the develop branch. Now you are able to choose both the ports in the configuration file. Maybe try a different port and see if that resolves your problem. I tested it on several devices and I cannot seem to reproduce the issue. As again, really thanks for your effort! I will put you in the readme file. Shall I link your twitter or github account?

vincentcox commented 6 years ago

The project evolved a bit since this pull request was started. I think that the drag and drop interface is great to work without parameters. Dropping the -p tag brought up some more problems along the way so I think I just keep it that way if people want to use the command line. However, I really appreciate your contribution and suggestion.