Added docker container for quick review of an application.

[vincentcox]

Can you confirm that the docker instance still works with https://github.com/vincentcox/StaCoAn/tree/develop? I am cleaning up the structure. Currently I am unable to run docker because I am running VMWare to test the different builds. Unfortunately, hyper-V does not like VMWare so I cannot test it on my device.

Build is passing, so if docker works for you, it will be merged to master.

[vincentcox]

I update the docker setup with a drag and drop interface. It's now pushed to develop. Again, I have no access to docker due vmware, so it would be a huge favour if you could test this again. Do you mind if I put you in a "special contributor's" tab in the README? If you like I link your GitHub or twitter account. Your docker idea and code gave this project something extra so I would like to express my appreciation.

[BBerastegui]

Hi ! I just took a look at it.

The docker now is much much smaller, but here: https://github.com/vincentcox/StaCoAn/blob/develop/src/helpers/server.py#L442

You have hardcoded a port (8080) for the report to be opened, but by default, the web server is running in port 8000, so when you click on it, you get an error, as the server is not running in that port.

Am I missing something here?

Feel free to add me wherever you want. Glad I helped a little !

[vincentcox]

Hi there,

You were correct!

Somehow my latest commit didn’t get trough.

Now it should work, can you try again?

I will add your twitter handle in the next commit! 🙌

On 26 Feb 2018, at 01:14, Borja Berastegui notifications@github.com wrote:

Hi ! I just took a look at it.

The docker now is much much smaller, but here: https://github.com/vincentcox/StaCoAn/blob/develop/src/helpers/server.py#L442

You have hardcoded a port (8080) for the report to be opened, but by default, the web server is running in port 8000, so when you click on it, you get an error, as the server is not running in that port.

Am I missing something here?

Feel free to add me wherever you want. Glad I helped a little !

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[BBerastegui]

When cloning the develop branch I still get the link to the port 8080, and the name of the report location is not ok neither (check the . and the underscores).

Link generated: http://localhost:8080/com_king.candycrushsaga.apk/report/start.html

Link corrected: http://localhost:8000/com_king_candycrushsaga_apk/report/start.html

[vincentcox]

Damn, will look at it this evening. Thanks for testing it!

[vincentcox]

Just to double check, did you changed https://github.com/vincentcox/StaCoAn/blob/develop/docker/Dockerfile#L19 to RUN git clone https://github.com/vincentcox/StaCoAn/ -b develop?

[BBerastegui]

Yup:

# git branch
* develop

The HTML I end up with is like this:

<a href="http://localhost:8080/com_king.candycrushsaga.apk/report/start.html" class="box__restart2" id="done_link" onclick="javascript:event.target.port=8080" role="button" target="_blank">Open report!</a>

[vincentcox]

https://github.com/vincentcox/StaCoAn/commit/b2099e38401e1d53ebd45d975a1026a7b3e9340e -> This fixes the path error you have. About your comment over the port; there are 2 ports used:

• 8000 for drag and drop server
• 8080 for the report server

[vincentcox]

https://github.com/vincentcox/StaCoAn/tree/develop#top-contributors There you go! 😃

[Ayowel]

@vincentcox Then, you might want to EXPOSE 8080 in the Dockerfile and update the readme