vincentdephily / emlop

EMerge LOg Parser
GNU General Public License v3.0
36 stars 4 forks source link

RUSTSEC-2020-0071: Potential segfault in the time crate #16

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

Potential segfault in the time crate

Details
Package time
Version 0.1.44
URL https://github.com/time-rs/time/issues/293
Date 2020-11-18
Patched versions >=0.2.23
Unaffected versions =0.2.0,=0.2.1,=0.2.2,=0.2.3,=0.2.4,=0.2.5,=0.2.6

Impact

Unix-like operating systems may segfault due to dereferencing a dangling pointer in specific circumstances. This requires an environment variable to be set in a different thread than the affected functions. This may occur without the user's knowledge, notably in a third-party library.

The affected functions from time 0.2.7 through 0.2.22 are:

The affected functions in time 0.1 (all versions) are:

Non-Unix targets (including Windows and wasm) are unaffected.

Patches

Pending a proper fix, the internal method that determines the local offset has been modified to always return None on the affected operating systems. This has the effect of returning an Err on the try_* methods and UTC on the non-try_* methods.

Users and library authors with time in their dependency tree should perform cargo update, which will pull in the updated, unaffected code.

Users of time 0.1 do not have a patch and should upgrade to an unaffected version: time 0.2.23 or greater or the 0.3. series.

Workarounds

No workarounds are known.

References

time-rs/time#293

See advisory page for additional details.

vincentdephily commented 2 years ago

Impact of an emlop segfault should be low, and I don't think there's a way to set the env var in production (though unittests do this), but we still want to clear that issue.

Looks like the fix in chrono will take some time, so it might be better to switch to time ~= 0.3, with a view towards implementing a --utc in the next release. I also want to support simpler date input formats for --from/--to, so this might be an occasion to get rid of chrono_english in favor of an ad-hoc implementation.

vincentdephily commented 2 years ago

Emlop no longer directly depends on chrono, but we still have it as a transitive dep.

vincentdephily commented 2 years ago

Fixed: lo longer depend on chrono or old time.