vincentdoerig / latex-css

LaTeX.css is a CSS library that makes your website look like a LaTeX document
https://latex.vercel.app
MIT License
2.76k stars 123 forks source link

Add 2px blue focus-frame (accessibility) and danish language file #16

Closed oleguldberg closed 4 years ago

oleguldberg commented 4 years ago

Using the keyboard to navigate (tab-key and/or accessive technology) having a focus highlight is very helpfull. So, this change adds a 2px blue focus frame.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vincentdoerig/latex-css/2rw7mw6v2 ✅ Preview: https://latex-css-git-fork-oleguldberg-master.vincentdoerig.now.sh

vincentdoerig commented 4 years ago

Thanks. Just one small criticism, the blue property doesn't go too well on the eyes in my opinion, would you mind changing it to something a bit darker, hsl(222, 68%, 35%) for example? You could also add a small offset to the outline, outline-offset: 2px;. What do you think is best in terms of accessibility?

oleguldberg commented 4 years ago

The outline-offset is great - adds readablity.

Colour is alway a point of discussion - I tend to favor the lighter blue as the darker blue is allmost black. I have added your darker blue - it might grow on me smile

vincentdoerig commented 4 years ago

Fair enough haha. I might have changed my mind again sorry, I actually really like how this looks (taken and adapted from the W3C website). What do you think?

image
a:focus {
  background: hsla(0, 0%, 75%, 0.25);
  border-bottom: 3px solid hsl(0, 0%, 45%);
  text-decoration: none;
}
oleguldberg commented 4 years ago

slick .. might bitch about the colour later grin.

Thanks a bunch!

oleguldberg commented 4 years ago

Damn - the "bottom line" will disapear when you "tab" to the bottom of the page:

image

image

so, I prefer the "box" to the underlined version.

vincentdoerig commented 4 years ago

Alright, so we are revisiting the boxed outline. You mentioned it being too dark, how about hsl(220, 90%, 52%), similar to blue but a bit less "aggressive".

image

vs

image
oleguldberg commented 4 years ago

Amazing - Thats great! The box is readable and the colour is great!