search

vincentdoerig / latex-css

LaTeX.css is a CSS library that makes your website look like a LaTeX document
https://latex.vercel.app
MIT License
2.74k stars 125 forks source link

Misc.table/hyphens fixes #22

Closed tiagofilipesilva closed 4 years ago

tiagofilipesilva commented 4 years ago

Fixing tables focusing on:

Fixes on hyphens properties.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vincentdoerig/latex-css/mue4ljmo4 ✅ Preview: https://latex-css-git-fork-tiagofilipesilva-master.vincentdoerig.now.sh

vincentdoerig commented 4 years ago

Isn't it a bit overkill to add ids and headers to such a simple table? Even the use of scope="col" would be exaggerated.

For simple tables that have the headers in the first row or column then it is sufficient to simply use the TH elements without scope. —W3C

tiagofilipesilva commented 4 years ago

It isn't and it does not comply with our accessibility standards.

vincentdoerig commented 4 years ago

our accessibility standards

Sorry, what? I agree these types of measures are useful on complex tables or tables with actual data, but the table here is just for visual reference and not intended to be read as an actual data table.

tiagofilipesilva commented 4 years ago

Ah, fair enough I see your point now, like the usage of <b> and <em>. It makes sense, then.

You should cherry-pick the fixes in hyphens and make the table valid for HTML5.