vincenthz / hs-connection

simple client connection library in haskell with builtin features: SSL/TLS, SOCKS, session management.
Other
61 stars 48 forks source link

Ambiguous docs on re-using TLS sessions #32

Closed duijf closed 1 year ago

duijf commented 6 years ago

Hello! I'm trying to implement TLS session re-use in one of our open source projects (https://github.com/channable/vaultenv/issues/37), but am having a few issues understanding the current status of support from this library.

The docs for settingDisableSession currently read "Disable session management. TLS/SSL connections will always re-established their context. Not Implemented Yet."

To me, it seems like it would mean "Disabling session management isn't implemented, sessions will always be re-used", but this code suggests that the actual re-use isn't implemented (since the default of the tls package is noSessionManager).

Because of the double negative in the docs, the wording is a bit ambiguous.

Questions:

Thanks for your work you put in this package, by the way :smile: