search

vincenthz / hs-cryptohash

efficient and practical cryptohashing in haskell. DEPRECATED in favor of cryptonite
Other
30 stars 24 forks source link

Handle unaligned loads on non-x86 targets #25

Closed figgles closed 1 year ago

figgles commented 10 years ago

This modifies the code to have two new functions: load32() and load64(). When ARCH_HAVE_UNALIGNED_LOAD is defined (e.g. x86), they are simple assignments, but otherwise, they use memcpy() to signal to gcc that the loads must be done in an unaligned fashion. This fixes issue #24.

nomeata commented 10 years ago

I just applied this patch to the Debian package and uploaded it to see how it works. I’ll report if it fixes our problems on sparc.

nomeata commented 10 years ago

Might take a while until I can report a result; libgmp-dev is currently not installable on sparc.

nomeata commented 10 years ago

Unfortunately, this did not solve the problem: haskell-cryptohash-0.11.4-2 in Debian has the patch applied, but haskell-tls still fails in the test suite.

figgles commented 10 years ago

Hey, I've been on vacation, but I'll check it out this week!

On Wednesday, May 7, 2014, Joachim Breitner notifications@github.com wrote:

Unfortunately, this did not solve the problem: haskell-cryptohash-0.11.4-2 in Debian has the patch applied, but haskell-tls still fails in the test suite.

— Reply to this email directly or view it on GitHubhttps://github.com/vincenthz/hs-cryptohash/pull/25#issuecomment-42395993 .

vincenthz commented 1 year ago

archiving repository