search

vincenthz / hs-cryptohash

efficient and practical cryptohashing in haskell. DEPRECATED in favor of cryptonite
Other
30 stars 24 forks source link

prefix all the internal C functions with cryptohash_ #38

Closed niteria closed 8 years ago

niteria commented 8 years ago

This fixes #37

Test Plan: cabal test

hvr commented 8 years ago

:+1: I ran into a similiar issue since symbols such as md5_init are quite popular in C libraries :-/

vincenthz commented 8 years ago

cryptonite already has this done, and it's where things are nowadays. My advice is to move your libraries / dependencies to using cryptonite

hvr commented 8 years ago

Sure, but there's at least an order of magnitude more code depending on cryptohash than cryptonite out there, e.g. c.f.

and since cryptohash isn't marked "whole-package-deprecated" either on Hackage, it's probably gonna take a long time to migrate the whole ecosystem away from cryptohash. But we certainly don't want to force everyone to migrate to cryptonite (which is not a drop-in replacement API-wise as far as I can see) by not fixing actual issues in cryptohash... :-)