search

vincenthz / hs-cryptohash

efficient and practical cryptohashing in haskell. DEPRECATED in favor of cryptonite
Other
30 stars 24 forks source link

Make benchmarks work with modern criterion #43

Closed RyanGlScott closed 6 years ago

RyanGlScott commented 8 years ago

Currently, the benchmarks fail to compile with criterion >= 1. This is my attempt at fixing them. (Unfortunately, criterion-1 removed bcompare, so I just flattened all of the bcompare'd tests.)

See also https://github.com/fpco/stackage/issues/1372#issuecomment-213020065 and https://github.com/iu-parfunc/sc-haskell/issues/7

bergmark commented 8 years ago

The benchmarks for this package has been disabled in stackage because of this issue. When a fix is published to hackage could you please send a PR to re-enable the benchmarks to stackage (it's in the expected-benchmark-failures section) or ping me?

Thanks!

RyanGlScott commented 6 years ago

It's unlikely this will ever be fixed.