vincenthz / ocaml-inotify

ocaml inotify binding
Other
12 stars 3 forks source link

Lwt/Async Support #1

Open rgrinberg opened 11 years ago

rgrinberg commented 11 years ago

Would be sweet to have support for Lwt and Async

vincenthz commented 11 years ago

i'm not using it much anymore, so it's unlikely i'll add such a thing myself (i'm not using lwt or async either), but a contributions to do that would be great indeed.

rgrinberg commented 11 years ago

OK, that's completely fine. Would you first accept contributions to convert the project into oasis first? It would make doing the rest of the work much easier (can specify optional dependcies and other things)

vincenthz commented 11 years ago

it's already using obuild which supports many more things compared to the makefile (see https://github.com/avsm/ocaml-cohttp/blob/master/cohttp.obuild for a more elaborate obuild).

I'm not against bundling oasis as well as long as it doesn't come with the many generate files.

rgrinberg commented 11 years ago

Ah, I haven't noticed the .obuild file in your repo. I immediately saw the Makefile and just assumed :D Will check it out since it definitely seems powerful and easy enough to use.

vincenthz commented 11 years ago

cool. let me know how it goes, or if you have any question.