vincentlaucsb / csv-parser

A high-performance, fully-featured CSV parser and serializer for modern C++.
MIT License
901 stars 150 forks source link

Fix invalid memory access issue in g++ builds #228

Closed vincentlaucsb closed 4 months ago

vincentlaucsb commented 4 months ago

Fix invalid memory access issues in g++ builds caused when accessing CSVField methods while using the CSVRow reverse iterator.

This was caused by a workaround to previous versions of g++ not supporting the use of std::shared_ptr as a pointer type in iterators, thus requiring the fallback use of raw pointers (which would cause the std::shared_ptr<CSVField> to go out of scope and get deleted.

Now that newer versions of g++ don't have this problem, we can remove the dubious workaround.

image