Changed the number of the cities, and replaced Null city name with '-'

vincentmorneau / oracle-geo-data

https://demo.insum.ca/ords/f?p=131

MIT License

22 stars 3 forks source link

Changed the number of the cities, and replaced Null city name with '-' #5

Closed Hawk707 closed 7 years ago

Hawk707 commented 7 years ago

Changed the number of the cities in readme.md to reflect the actual number in cities.sql : 48,314.
Replaced empty city name for city ID 22269 with '-' (zero length string fails Not null constraint set on that column). Tested on Oracle 12.1C

vincentmorneau commented 7 years ago

I should probably remove city_id = 22269.

Still, I get

select count(*) from cities;
-- 48312

There's probably another one failing.

Hawk707 commented 7 years ago

I also thought of removing city_id = 22269. But was not sure whether to reseync the sequence or leave the gap. Another thing, in cities.sql the sequence created after insert starts with 48315, which also suggest the number of rows before insert was 48314.

My run for the following: select count(*) from cities; --48314

So as you said, there's probably another one failing

vincentmorneau commented 7 years ago

Closing this as the new data source does not match the PR code.