vincentmorneau / oracle-geo-data

https://demo.insum.ca/ords/f?p=131
MIT License
22 stars 3 forks source link

Severe errors in list of Australian states/territories #8

Closed skissane closed 7 years ago

skissane commented 7 years ago

Many of the listed Australian states/territories aren't states or territories of Australia at all:

insert into states (state_id, name, country_id) values (245, 'Auckland', 13);
insert into states (state_id, name, country_id) values (247, 'Balgowlah', 13);
insert into states (state_id, name, country_id) values (248, 'Balmain', 13);
insert into states (state_id, name, country_id) values (249, 'Bankstown', 13);
insert into states (state_id, name, country_id) values (250, 'Baulkham Hills', 13);
insert into states (state_id, name, country_id) values (251, 'Bonnet Bay', 13);
insert into states (state_id, name, country_id) values (252, 'Camberwell', 13);
insert into states (state_id, name, country_id) values (253, 'Carole Park', 13);
insert into states (state_id, name, country_id) values (254, 'Castle Hill', 13);
insert into states (state_id, name, country_id) values (255, 'Caulfield', 13);
insert into states (state_id, name, country_id) values (256, 'Chatswood', 13);
insert into states (state_id, name, country_id) values (257, 'Cheltenham', 13);
insert into states (state_id, name, country_id) values (258, 'Cherrybrook', 13);
insert into states (state_id, name, country_id) values (259, 'Clayton', 13);
insert into states (state_id, name, country_id) values (260, 'Collingwood', 13);
insert into states (state_id, name, country_id) values (261, 'Frenchs Forest', 13);
insert into states (state_id, name, country_id) values (262, 'Hawthorn', 13);
insert into states (state_id, name, country_id) values (263, 'Jannnali', 13);
insert into states (state_id, name, country_id) values (264, 'Knoxfield', 13);
insert into states (state_id, name, country_id) values (265, 'Melbourne', 13);
insert into states (state_id, name, country_id) values (268, 'Perth', 13);
insert into states (state_id, name, country_id) values (272, 'Templestowe', 13);
insert into states (state_id, name, country_id) values (274, 'Werribee south', 13);
insert into states (state_id, name, country_id) values (276, 'Wheeler', 13);

Most of these are cities/towns/suburbs in Australian states/territories, not states or territories. Auckland is a city in another country (New Zealand).

The only correct states/territories entries for Australia are:

insert into states (state_id, name, country_id) values (246, 'Australian Capital Territory', 13);
insert into states (state_id, name, country_id) values (266, 'New South Wales', 13);
insert into states (state_id, name, country_id) values (267, 'Northern Territory', 13);
insert into states (state_id, name, country_id) values (269, 'Queensland', 13);
insert into states (state_id, name, country_id) values (270, 'South Australia', 13);
insert into states (state_id, name, country_id) values (271, 'Tasmania', 13);
insert into states (state_id, name, country_id) values (273, 'Victoria', 13);
insert into states (state_id, name, country_id) values (275, 'Western Australia', 13);

Furthermore, if you want factual completeness, there is one more mainland (as opposed to external) Australian territory which is not listed, Jervis Bay Territory. (Not many people live there – most of it is occupied by a naval base and a national park, with only one small village of civilian inhabitants – and hence not many people realise it exists – but legally speaking, it is a distinct territory.)

(Most external territories of Australia you have listed as countries rather than states/territories. Given most of them have separate ISO 3166-1 codes, that is probably okay.)

vincentmorneau commented 7 years ago

According to the new data source, here are australian states/territories/regions:

Can you confirm? You had only 8 above.

vincentmorneau commented 7 years ago

fixed in https://github.com/vincentmorneau/oracle-countries-states-cities/commit/4ef3f9cfcf06d4cd27733da1a66e9ae9dbdc8baf