vincentporte / fastapi_sqlachemy2_async

FastAPI x sqlAlchemy 2 x postgresql, async mode

MIT License

2 stars 0 forks source link

feat(chore): simplify DB test session management #1

Open vincentporte opened 1 year ago

vincentporte commented 1 year ago

Description

🎸 set db_session as fixture for tests

Type of change

[ ] 🌋 Bug fix (non-breaking change which fixes an issue)
[ ] 🎢 New feature (non-breaking change which adds functionality)
[ ] 🥁 Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] 🎨 change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

vincentporte commented 1 year ago

test_create_user_async fails.

Failed: [undefined]Fixture "db_session" called directly. Fixtures are not meant to be called directly,
but are created automatically when test functions request them as parameters.

Neither

def test_create_user_async(client, db_session)

nor

@pytest.mark.asyncio
async def test_create_user_async(client, db_session):
    # Ensure the users list is empty before creating a new user
    response = await client.get("/api/users/")
    assert response.status_code == 200

solve the issue