search

vincentpotato / meteor-astronomy-security

GNU General Public License v2.0
0 stars 1 forks source link

Update for Astronomy 2.0 #1

Open meecect opened 3 years ago

meecect commented 3 years ago

This package looks great! Any plans to update it to support current Astronomy and Meteor packages?

meecect commented 3 years ago

I read through the code and started migrating the functionality to support astronomy 2.0. It looks like, for the most part, I can implement 90% of the package using Astronomy behaviors.

I created a behavior called 'acl' and have put all the additional fields in them and moved most of the document-level functions over helpers.

I am focused right now on ACL and query building helpers only. As I have time I will implement the event permissions checks and the other role-related functions.

My current feeling is that it should build on top of the meteor-roles (allanning-roles) package for actually maintaining roles, and that the options passed into the acl behavior should merely specify the role that should be checked for each operation.

This maintains flexibility and means that people can choose one package for maintaining roles, while this package will keep track of and check against the roles specified for specific class-level actions as well as adding per-use and per-role document level permissions.

Thoughts? I'm also happy to create that as a separate module and credit you as the originator of most of the code. I'm really just moving stuff around, cutting and pasting, and renaming stuff.