search

vincentsarago / color-operations

Apply basic color-oriented image operations. Fork of rio-color
Other
9 stars 3 forks source link

arm64 version #4

Open demiurg opened 1 year ago

demiurg commented 1 year ago

Thank you for the effort with this package, and rio-tiler. I was trying to use micromamba on arm64, and I think I'm stuck not being able to conda install rio-tiler from conda-forge, because there is no arm64 version of this color-operations package.

I know this is a niche usecase, but I thought I should at least mention this. I also can see this package is cython, and builds for osx, which I assume might include arm support. So, maybe it's not a lot of effort to add arm64 as build target.

I'm not sure how to do this, but let me know if you have any interest in adding arm64 support.

vincentsarago commented 1 year ago

I though we were creating the wheels for arm64 https://github.com/vincentsarago/color-operations/blob/main/.github/workflows/ci.yml#L80 🤔

https://files.pythonhosted.org/packages/33/f1/f5309fbedb59a1d3dc4be419b5daf8316a219d0fb64dc12158994bf33269/color_operations-0.1.1-cp311-cp311-macosx_11_0_arm64.whl

vincentsarago commented 1 year ago

oh you mean non MacOS arm64 🤦

demiurg commented 1 year ago

yes :) AWS Graviton, specifically. In dockerfile that looks like linux/amd64/v8 or --platform linux/arm64

vincentsarago commented 1 year ago

I'm not an expert in how we create wheels but everything is done using https://cibuildwheel.readthedocs.io/en/stable/ if you want to have a look

demiurg commented 1 year ago

Thanks, I'll take a look!

vincentsarago commented 1 year ago

@demiurg did you look more into this? 🙏

demiurg commented 1 year ago

My bad, thanks for reminder. I forgot about this. But, having looked at the cibuildwheel, it appears that the lines in these examples can be added?

      - name: Build wheels
        uses: pypa/cibuildwheel@v2.15.0
        env:
          # configure cibuildwheel to build native archs ('auto'), and some
          # emulated ones
          CIBW_ARCHS_LINUX: auto aarch64 ppc64le s390x

from https://github.com/pypa/cibuildwheel/blob/main/examples/github-with-qemu.yml#L27

vincentsarago commented 9 months ago

let's see if https://github.com/vincentsarago/color-operations/commit/68424ada864605072c40b6d9d7715ae7b67595dd does it

vincentsarago commented 9 months ago

:-( it failed for python 3.8 https://github.com/vincentsarago/color-operations/actions/runs/7245685902/job/19736217411

vincentsarago commented 9 months ago

ref https://github.com/scipy/oldest-supported-numpy/issues/80

demiurg commented 9 months ago

Exciting :)