search

vincentvikram / history-maker

Technology framework for learning thinking skills in history
http://planethackers.in
GNU Affero General Public License v3.0
2 stars 9 forks source link

wrap text within svg or hide text #9

Open vincentvikram opened 9 years ago

vincentvikram commented 9 years ago

right now the text spills outside the svg making the diagram look unreadable and ugly. There seems to be a solution https://stackoverflow.com/questions/4991171/auto-line-wrapping-in-svg-text

TechMky commented 6 years ago

I contacted the support team of Jointjs and came to know that the textWrap attribute is not supported in Jointjs v0.9. Although the recent commit by @vincentvikram , 62cdd2f69409fee77ae32572a7273ec057cd6c52 has solved the issue #20 , the overall structure of the project is still as per the version 0.9.

So now the workaround for this issue as of now is to use breakText attribute. This is again not a fully fledged solution and hence I need to know how to take this forward. @vincentvikram sir, should I go on with breakText ?

vincentvikram commented 6 years ago

On Wed, 15 Aug 2018 at 18:39, Yashasvi notifications@github.com wrote:

I contacted the support team of Jointjs and came to know that the textWrap attribute is not supported in Jointjs v0.9. Although the recent commit by @vincentvikram https://github.com/vincentvikram , 62cdd2f https://github.com/vincentvikram/history-maker/commit/62cdd2f69409fee77ae32572a7273ec057cd6c52 has solved the issue #20 https://github.com/vincentvikram/history-maker/issues/20 , the overall structure of the project is still as per the version 0.9.

So now the workaround for this issue as of now is to use breakText attribute. This is again not a fully fledged solution and hence I need to know how to take this forward. @vincentvikram https://github.com/vincentvikram sir, should I go on with breakText ?

Breaktext appears to be the best solution at the moment. Have you looked at https://stackoverflow.com/questions/23823295/word-wrapping-in-jointjs

TechMky commented 6 years ago

Yes, I am thinking of something similar.

TechMky commented 6 years ago

@vincentvikram there is a function called createNewItem() which is defined in the app-bundle.js which again comes from the gulp command. Now the issue is that the function is defined in the app-bundle.js itself (as I can't find that function anywhere else in the code). So, after running the gulp command, the changes made will get overwritten. I propose to move that function definition into misc folder in a separate file.

P.S. Here is the outcome if we go with the breakText() method. capture

vincentvikram commented 6 years ago

Please go ahead. Will test it from your repo before integrating

On Fri, 17 Aug 2018 at 17:22, Yashasvi notifications@github.com wrote:

@vincentvikram https://github.com/vincentvikram there is a function called createNewItem() which is defined in the app-bundle.js which again comes from the gulp command. Now the issue is that the function is defined in the app-bundle.js itself (as I can't find that function anywhere else in the code). So, after running the gulp command, the changes made will get overwritten. I propose to move that function definition into misc folder in a separate file.

P.S. Here is the outcome if we go with the breakText() method. [image: capture] https://user-images.githubusercontent.com/25933059/44264882-df6f7e00-a241-11e8-844f-2cc8a629df99.JPG

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vincentvikram/history-maker/issues/9#issuecomment-413841355, or mute the thread https://github.com/notifications/unsubscribe-auth/AAleYE9dSYh_fgVkLjBI1bDyXx3kp_4Zks5uRq4sgaJpZM4GeBzC .