search

vincentwolsink / home_assistant_micronova_agua_iot

Home Assistant integration controlling heating devices connected via the Agua IOT platform of Micronova
Apache License 2.0
25 stars 15 forks source link

Update climate.py #1

Closed Donder24 closed 2 years ago

Donder24 commented 2 years ago

Hi, I'm new with API's, code and Home assistant but I found some extra states for the Piazetta stove, probably also for other stoves. START and PELLET LOADING are working fine, the other 2 states aren't working. Since I don't have experience with reading API's, the succesfull states are lucky shots... Sorry if I'm wrongly using the Github Pull requests, Github is also new... Like I've vreated a second pull request for the const.py changes which are also adjusted.

vincentwolsink commented 2 years ago

Hi @Donder24. Thanks for your PR. Can you maybe explain what your goal is with this change? You are importing contants that don't exist in the file you are importing from. Also, to bring any functionality, they need to be used/mapped somewhere.

Donder24 commented 2 years ago

Helo Vincent,

Yeah, I thought so I was doiing something wrong...

But the "Pellet loading " state worked, so I continue with the other states.

My goal was to add the event-states the stove can have. Like "starting", "light flame",... . One of the states I wanted especially was : "pellet lack" or other Error states. So I can send notifications through HA to our cellphones for example in case we are running out off pellets.

Sorry for messing arround. I´dd better first have a better look how this code works... before tryiing.

Greetings Tom

Op do 7 apr. 2022 09:57 schreef Vincent Wolsink @.***>:

Hi @Donder24 https://github.com/Donder24. Thanks for your PR. Can you maybe explain what your goal is with this change? You are importing contants that don't exist in the file you are importing from. Also, to bring any functionality, they need to be used/mapped somewhere.

— Reply to this email directly, view it on GitHub https://github.com/vincentwolsink/py-agua-iot/pull/1#issuecomment-1091236911, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT473GOOBTAHUGNXGQOR6DLVD2IOPANCNFSM5QZ7PVXQ . You are receiving this because you were mentioned.Message ID: @.***>

vincentwolsink commented 2 years ago

Hi Tom,

I just found the issue you opened here https://github.com/fredericvl/py-agua-iot/issues/30 I will take a look at adding the extra states/errors.

vincentwolsink commented 2 years ago

I updated the status messages here https://github.com/vincentwolsink/py-agua-iot/commit/e4681e9e02f616130599da28eb05a94c355ef187

You should now be able to see when the pellets are depleted.

Donder24 commented 2 years ago

Hello Vincent,

Could you help me out? I imported this repo through HACS to have your latest version. But the state" Pellet Depleted" doesn't seem to work for me. Do I have to do something else to get this working?

Thanks a lot for your help!

vincentwolsink commented 2 years ago

How do you read the state? And what output do you get?

I tested it on my own Ravelli stove, but maybe your stove uses different state codes.

Donder24 commented 2 years ago

sorry, offline for a few days.

I'm having a Piazetta stove. I read the state via the climate-integration but I've extracted the states through a template sensor.

I'm reading the "human_device_state" , "device_state" and "alarm_state" but none off them is returning something that makes sense. if the pellets are depleted, It just returns the state "on"

What I was wondering, ( but I' don't know how this really works) you made changes in the one file I can not find in Home assistant... Isn't there a way, I can write to a debug/log file the states so I can see what's the correct code? Something like "Debug.print...." Or should I be able to access the API without code?

Op vr 8 apr. 2022 om 22:27 schreef Vincent Wolsink @.***

:

How do you read the state? And what output do you get?

I tested it on my own Ravelli stove, but maybe your stove uses different state codes.

— Reply to this email directly, view it on GitHub https://github.com/vincentwolsink/py-agua-iot/pull/1#issuecomment-1093323464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT473GLX7LL2AGBFSSXH7RDVECJCJANCNFSM5QZ7PVXQ . You are receiving this because you were mentioned.Message ID: @.***>