vincentwolsink / home_assistant_micronova_agua_iot

Home Assistant integration controlling heating devices connected via the Agua IOT platform of Micronova
Apache License 2.0
27 stars 15 forks source link

Dynamically adjust climate entity to stove mode when having a hybrid stove #97

Closed vincentwolsink closed 10 months ago

vincentwolsink commented 11 months ago

The climate entity now dynamically adjusts to the mode of the stove, and displays the current mode by using a preset. Please let me know what you think (and if it works correctly) @jipem01

jipem01 commented 11 months ago

I reviewed the code and it should work, and yes it will be good to have the climate entity switching from one mode to other automatically. I'll try to test it soon.

But I see interest for keeping numbers for power_set and power_wood_set : -> Automations : I'm using the scheduler to get rid of the poor programmation capacity (only 4 program possible), and also adapt heating in my home depending on presences... By automation I should be able to define on/off/target temp/fan mode/power for each time frame. If the climate entity switch from wood to pellet, i could not use it in automation (cause i don't know if i'm setting wood power or pellet power, and in each time frame i need to set both), or I have to add more complex automation to set current power and to set back good power each time the stove change mode dending on current schedule... By having the entities available, i could set them at any moment and it stay in memory for the stove point of view. Way more easier and simpler!

But to not add duplicate entities when not needed, maybe we should create this two entities only when we detect an hybrid stove.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

vincentwolsink commented 10 months ago

Now keeping the separate power controls in case of a hybrid stove.

jipem01 commented 10 months ago

It seams to work but need improvements :

vincentwolsink commented 10 months ago

The entity display is exactly how it should be. The fan should switch between pellet and wood power and the preset mode should display the current fuel.

can you make a screenshot of the climate card?

jipem01 commented 10 months ago

Good! Here is the screenshot : Screenshot_20231111-203228_Home Assistant

And associated diag file config_entry-aguaiot-8e52fb5148a6b6bd4aba66b72c2ae9aa.json-5.txt

vincentwolsink commented 10 months ago

The climate card also looks good to me? I don’t know what “étient” exactly means. But it looks like it is heating on wood?

Using a preset mode for the fuel might be a bit odd. But unfortunately for stove mode HA only supports a built-in list which doesn’t support our usecase.

jipem01 commented 10 months ago

"Eteint" means off.

vincentwolsink commented 10 months ago

Fixed hvac_action (stove status) in #99