vincenzopalazzo / lampo.rs

lampo (lightning in Italian) is a experimental implementation of a tiny lightning node
http://lampo.devcrew.cc
BSD 3-Clause "New" or "Revised" License
31 stars 14 forks source link

fundchannel should return a txid inside the json respose #236

Closed vincenzopalazzo closed 1 week ago

vincenzopalazzo commented 1 month ago

We are missing the more important information that is the txid

➜  ~ lampo-cli --network signet fundchannel --node_id 026b92e6cc3e0f24b42494672ecf65f3d147b9deb95186bf024da7a7745008ee75  --amount 200000 --public true
{
  "node_id": "026b92e6cc3e0f24b42494672ecf65f3d147b9deb95186bf024da7a7745008ee75",
  "amount": 200000,
  "public": true,
  "push_mst": 0,
  "to_self_delay": 2016,
  "tx": {
    "version": 2,
    "lock_time": 0,
    "input": [
      {
        "previous_output": "ac9ee361e0ec07f919f6b9dc07c2fd21f05ef559326b45e6f889c6e37bb6f32b:0",
        "script_sig": "",
        "sequence": 4294967294,
        "witness": [
          "55846fb5c7ef20f0ba055a8cc9c3d9e97c4323d02bbf9b9a88490d4fd24cacde5afeac503ca26a163089c3b3a4246340cfffa2dcc7388c5055d139871e101449"
        ]
      },
      {
        "previous_output": "9891b12bb6e608bada7296bdc47bd424df16ad4ac14330c0f003335df18b9b03:0",
        "script_sig": "",
        "sequence": 4294967294,
        "witness": [
          "f6e0d011c6052ccf697ed5a5c48cee62acf5f2aed548bf27d71b31951072b5ef150a49897ec260a0c80dc4246903affb62bb21ad80036b2a0ec551c3b1ccc6fa"
        ]
      }
    ],
    "output": [
      {
        "value": 1059880,
        "script_pubkey": "51209a9177c972471352f58c4b9b8fedcaea9b0230edc1565c671644119e84059caf"
      },
      {
        "value": 200000,
        "script_pubkey": "0020ad50c2d4bbcc6db44e70bdf30acc123bd5b62652df250bd7fb29641d8083cd70"
      }
    ]
  }
}
vincenzopalazzo commented 1 week ago

Trying to bump this in the following release

chrisguida commented 1 week ago

I'll look at this tomorrow, sorry for the delay!

vincenzopalazzo commented 1 week ago

I'll look at this tomorrow, sorry for the delay!

No problem it is my fault that I just noted that we do not have this