vincep5 / MMM-MyStandings

MagicMirror module to get ESPN standings for the major US sports
14 stars 6 forks source link

showByDivision: 0 breaks NHL standings #10

Closed serenewaffles closed 3 years ago

serenewaffles commented 3 years ago

Expected behavior: view league wide standings Actual behavior: no standings are displayed Config:

{
                        module: "MMM-MyStandings",
                        position: "top_left",
                        config: {
                                updateInterval: 60 * 60 * 1000, // every 60 minutes
                                rotateInterval: 1 * 10 * 1000, // every 1 minute
                                sports: [
                                        { league: "NHL", groups: ["Central Division", "East Division", "North Division", "West Division"] },
},
                                ],
                                nameStyle: "short",
                                showLogos: true,
                                useLocalLogos: false,
                                showByDivision: 0,
                                fadeSpeed: 0,
                        }
                }
vincep5 commented 3 years ago

try putting it as false instead of 0 showByDivision: false

serenewaffles commented 3 years ago

I've got them to show up now, but they're still split by division and showing one after the other. I thought this would show overall standings; is that not the case?

vincep5 commented 3 years ago

yes, correct. It's split out by division, I dont have the ability to group by conference at this point without some major code changes.

serenewaffles commented 3 years ago

Thanks! I'll open an enhancement issue for league standings.