search

vincep5 / MMM-MyStandings

MagicMirror module to get ESPN standings for the major US sports
14 stars 6 forks source link

Division Rotation #2

Closed bam7 closed 5 years ago

bam7 commented 5 years ago

I'm seeing behavior that the rotation goes all the way through the divisions, but stops at the last one and doesn't start over again. (ex, MLB standings go thru all divisions, but stop rotating after NL WEST)

This happens when I use the long notation with all the divisions defined, or the short notation with just { league: "MLB" } defined.

There are no errors and the data is correct, but it just doesn't re-start it's rotation after cycling thru them once.

Thoughts?

vincep5 commented 5 years ago

I have a bug, thanks for letting me know. I will check in the fix and you can git pull the changes.

bam7 commented 5 years ago

The update appears to have worked. The rotation is working. Thanks

On Wed, May 8, 2019 at 12:01 PM vin p notifications@github.com wrote:

I have a bug, thanks for letting me know. I will check in the fix and you can git pull the changes.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vincep5/MMM-MyStandings/issues/2#issuecomment-490546461, or mute the thread https://github.com/notifications/unsubscribe-auth/AMATTLQDNYSBYSB5NRJWAY3PUL2NZANCNFSM4HLR4FEA .