search

vincep5 / MMM-MyStandings

MagicMirror module to get ESPN standings for the major US sports
14 stars 6 forks source link

NBA by Conference? #8

Open chansters opened 3 years ago

chansters commented 3 years ago

Thanks for this module ! It's great ! Instead of breaking out the table by Divisions, is it possible for NBA to show by East and West Conferences instead?

I've set "showByDivision: false" but it still groups by division.

vincep5 commented 3 years ago

Thanks, that would be a slightly different API call and some more code to change. I'm not actively making changes to this, but if anyone wants to submit a PR for it.

chansters commented 3 years ago

Thanks for responding. I totally understand you are not actively maintaining this. It's a great module.

vincep5 commented 3 years ago

Thanks! Yes, though I agree by Conference would be nice as the NBA playoffs get closer

nemmy187 commented 1 year ago

Hi there,

I know it's been almost two years since you asked this question, but I just installed this module and managed to get this feature working on my mirror. If you change row 278 of MMM-MyStandings.js to sport = "basketball/nba/standings?level=2&sort=gamesbehind:asc,winpercent:desc";

Then update your config groups to "Western Conference" and "Eastern Conference", it should aggregate the standings by conference. { league: "NBA", groups: ["Eastern Conference", "Western Conference"] }

Not sure if other fans would agree that this is the way NBA standings should be read, but I could certainly submit a PR if others agree.